Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TargetPopulation and HouseholdSelection models #4581

Merged
merged 56 commits into from
Feb 13, 2025

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Jan 20, 2025

  • AB#215791: Remove models

  • coverage backend

  • AB#231267: FE Changes (fix Payment Verification Page)

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Jan 20, 2025
@pavlo-mk pavlo-mk self-assigned this Jan 20, 2025
@pavlo-mk pavlo-mk marked this pull request as draft January 20, 2025 15:03
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 95.57522% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.82%. Comparing base (ce71614) to head (67e685b).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/targeting/steficon.py 0.00% 2 Missing ⚠️
src/hct_mis_api/apps/payment/api/filters.py 50.00% 1 Missing ⚠️
src/hct_mis_api/apps/registration_data/admin.py 0.00% 1 Missing ⚠️
src/hct_mis_api/apps/steficon/admin.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4581      +/-   ##
===========================================
+ Coverage    85.35%   85.82%   +0.46%     
===========================================
  Files          546      544       -2     
  Lines        36683    35964     -719     
===========================================
- Hits         31312    30867     -445     
+ Misses        5371     5097     -274     
Flag Coverage Δ
e2e 60.85% <73.45%> (+0.02%) ⬆️
unittests 84.29% <95.57%> (+0.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk changed the title WIP // Remove TargetPopulation and HouseholdSelection models Remove TargetPopulation and HouseholdSelection models Jan 31, 2025
@pavlo-mk pavlo-mk marked this pull request as ready for review January 31, 2025 14:58
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Jan 31, 2025
@pavlo-mk pavlo-mk enabled auto-merge (squash) February 12, 2025 14:48
src/hct_mis_api/apps/household/forms.py Outdated Show resolved Hide resolved
src/hct_mis_api/apps/household/serializers.py Outdated Show resolved Hide resolved
src/hct_mis_api/apps/payment/filters.py Outdated Show resolved Hide resolved
src/hct_mis_api/apps/payment/filters.py Outdated Show resolved Hide resolved
@pavlo-mk pavlo-mk merged commit a92ff45 into develop Feb 13, 2025
13 checks passed
@pavlo-mk pavlo-mk deleted the remove_models_tp branch February 13, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants