Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT: ICU-22907 MF2: Finish updating spec tests and implement required test functions #3216

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Nov 14, 2024

  1. ICU-22908 MF2: Update spec tests and update implementation for recent…

    … spec changes
    
    Updating the spec tests requires two implementation changes:
    * Match on variables rather than expressions --
      see unicode-org/message-format-wg#877
    * Require attribute values to be literals (if present) --
      see unicode-org/message-format-wg#894
    
    This updates the spec tests to commit 6c3704f41a9c24427126429fb43992b03609dfc8
    in https://github.com/unicode-org/message-format-wg/ . Any changes
    following that commit will be addressed in a future PR.
    catamorphism committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    ed61179 View commit details
    Browse the repository at this point in the history
  2. ICU-22908 MF2: Finish updating spec tests and implement required test…

    … functions
    
    Implement :test:format, :test:select, and :test:function, which are
    required by the new `pattern-selection.json` tests.
    
    Change the internal value representation in the formatter in order to
    support some of the test cases (binding the results of selectors to a
    variable).
    catamorphism committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    383684b View commit details
    Browse the repository at this point in the history
  3. ICU-22908 MF2: Finish updating spec tests and implement required test…

    … functions
    
    Add exception to dependency checker script
    catamorphism committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    6ffd33e View commit details
    Browse the repository at this point in the history
  4. Fix leaks

    catamorphism committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    26297ef View commit details
    Browse the repository at this point in the history
  5. Fix warning

    catamorphism committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    43b0280 View commit details
    Browse the repository at this point in the history