Make some traits pub(crate) if they are able to be made pub(crate)

unicode-org · Nov 21, 2023 · bed0ef8 · bed0ef8
1 parent 1c0b95e
commit bed0ef8
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/components/calendar/src/calendar_arithmetic.rs b/components/calendar/src/calendar_arithmetic.rs
@@ -10,7 +10,7 @@ use tinystr::tinystr;
 // Note: The Ord/PartialOrd impls can be derived because the fields are in the correct order.
 #[derive(Debug, Hash, Eq, PartialEq, Ord, PartialOrd)]
 #[allow(clippy::exhaustive_structs)] // this type is stable
-pub struct ArithmeticDate<C> {
+pub(crate) struct ArithmeticDate<C> {
     pub year: i32,
     /// 1-based month of year
     pub month: u8,
@@ -30,7 +30,7 @@ impl<C> Clone for ArithmeticDate<C> {
 #[allow(dead_code)] // TODO: Remove dead code tag after use
 pub(crate) const MAX_ITERS_FOR_DAYS_OF_MONTH: u8 = 33;
 
-pub trait CalendarArithmetic: Calendar {
+pub(crate) trait CalendarArithmetic: Calendar {
     fn month_days(year: i32, month: u8) -> u8;
     fn months_for_every_year(year: i32) -> u8;
     fn is_leap_year(year: i32) -> bool;

diff --git a/components/datetime/src/datetime.rs b/components/datetime/src/datetime.rs
@@ -20,7 +20,7 @@ use icu_provider::prelude::*;
 use writeable::Writeable;
 
 use crate::{
-    calendar, input::DateInput, input::DateTimeInput, input::IsoTimeInput, CldrCalendar,
+    calendar, calendar::CldrCalendar, input::DateInput, input::DateTimeInput, input::IsoTimeInput,
     DateTimeError, FormattedDateTime,
 };
 

diff --git a/components/datetime/src/zoned_datetime.rs b/components/datetime/src/zoned_datetime.rs
@@ -12,6 +12,7 @@ use writeable::Writeable;
 
 use crate::{
     calendar,
+    calendar::CldrCalendar,
     format::zoned_datetime::FormattedZonedDateTime,
     input::{DateTimeInput, TimeZoneInput},
     options::DateTimeFormatterOptions,
@@ -22,7 +23,7 @@ use crate::{
     },
     raw,
     time_zone::TimeZoneFormatterOptions,
-    CldrCalendar, DateTimeError,
+    DateTimeError,
 };
 
 /// The composition of [`TypedDateTimeFormatter`](crate::TypedDateTimeFormatter) and [`TimeZoneFormatter`].

diff --git a/experimental/zerotrie/src/builder/nonconst/store.rs b/experimental/zerotrie/src/builder/nonconst/store.rs
@@ -10,7 +10,7 @@ use alloc::collections::VecDeque;
 use alloc::vec::Vec;
 
 /// A trait applied to a data structure for building a ZeroTrie.
-pub trait TrieBuilderStore {
+pub(crate) trait TrieBuilderStore {
     /// Create a new empty store.
     fn atbs_new_empty() -> Self;