Remove BCP-47 APIs from AnyCalendarKind, use CalendarAlgorithm instead
#6228
Conversation
| /// Construct from a BCP-47 byte string | ||
| /// | ||
| /// Returns `None` if the calendar is unknown. | ||
| pub fn get_for_bcp47_bytes(x: &[u8]) -> Option<Self> { |
There was a problem hiding this comment.
question: is there a valid alternative to use besides get_for_bcp47_bytes and as_bcp47_string?
temporal_rs uses these methods downstream, but maybe there's a better approach to use
There was a problem hiding this comment.
Yes, the API on CalendarAlgorithm. That actually complies with BCP-47, unlike this which fails on islamic-rgsa, and accepts japanext.
There was a problem hiding this comment.
Perfect! Thanks for the confirmation 😄
At a glance, it looks like it is more aligned, which is nice. Is there any handling for islamicc though? Although, that may be changing with the hijri rename
There was a problem hiding this comment.
@zbraniecki do preference support aliases?
| Japanese => CalendarAlgorithm::Japanese, | ||
| JapaneseExtended => CalendarAlgorithm::Japanese, |
There was a problem hiding this comment.
Thought: This is lossy.
I guess we can fix this when https://unicode-org.atlassian.net/browse/CLDR-15669 gets implemented.
robertbastian
requested review from
Manishearth,
zbraniecki and
nciric
as code owners
| Japanese => CalendarAlgorithm::Japanese, | ||
| JapaneseExtended => CalendarAlgorithm::Japanese, |
#6227