Start RBAC Work #89
Merged
Start RBAC Work #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users have access to APIs based on RBAC, so a non-admin user will not be able to see group memberships, edit projects etc. This introduces an initial framework to block access to these APIs (thus avoiding API error toasts), and instead present an error screen. Obviously this is an initial hack to see what works and what doesn't, so liable to change, but it appears to do what we want it to! Additionally fixes a problem with flavor selection not working due to the IDs not being properly scoped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users have access to APIs based on RBAC, so a non-admin user will not be able to see group memberships, edit projects etc. This introduces an initial framework to block access to these APIs (thus avoiding API error toasts), and instead present an error screen. Obviously this is an initial hack to see what works and what doesn't, so liable to change, but it appears to do what we want it to! Additionally fixes a problem with flavor selection not working due to the IDs not being properly scoped.