Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't show cmd k on phones #2707

Merged
merged 5 commits into from
Aug 9, 2024
Merged

don't show cmd k on phones #2707

merged 5 commits into from
Aug 9, 2024

Conversation

Swepool
Copy link
Contributor

@Swepool Swepool commented Aug 9, 2024 •
edited
Loading

closes #2701

@Swepool Swepool added the A-app Area: app.union.build label Aug 9, 2024
@Swepool Swepool self-assigned this Aug 9, 2024
@Swepool Swepool requested a review from cor as a code owner August 9, 2024 09:19
@netlify Netlify
Copy link

netlify bot commented Aug 9, 2024 •
edited
Loading

👷 Deploy request for unionlabs pending review.

A Netlify team Owner will need to approve the deploy before you can run your build.

Are you a team Owner? Visit the deploys page to approve it →

Need more help? Learn more in the Netlify docs →

Name Link
🔨 Latest commit 8ca84a3

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024 •
edited
Loading

App 🤌

🌎 Deploying...
✨ Deployment complete! Take a peek over at https://dbd3a1e4.app-1b1.pages.dev

cor
cor requested changes Aug 9, 2024
View reviewed changes
Copy link
Contributor

@cor cor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image looks like this approach does not work in safari

@Swepool Swepool requested a review from cor August 9, 2024 12:23
Swepool
Swepool commented Aug 9, 2024
View reviewed changes
Copy link
Contributor Author

@Swepool Swepool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed approach on this

@cor cor changed the title feat(app): check if keyboard don't show cmd k on phones Aug 9, 2024
@cor cor merged commit ea2e817 into main Aug 9, 2024
15 checks passed
@cor cor deleted the detect-keyboard branch August 9, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cor cor cor approved these changes

Assignees

@Swepool Swepool

Labels
A-app Area: app.union.build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect if user has keyboard
2 participants
@Swepool @cor