Merge pull request #4419 from unisonweb/travis/4415

Fix name resolution bug in the parser

parser-typechecker/src/Unison/UnisonFile/Names.hs

@@ -108,7 +108,7 @@ variableCanonicalizer vs =
     suffix <- Name.suffixes n
     pure (Var.named (Name.toText suffix), v)
   where
-    done xs = Map.fromList [ (k, v) | (k, nubOrd -> [v]) <- Map.toList xs ]
+    done xs = Map.fromList [ (k, v) | (k, nubOrd -> [v]) <- Map.toList xs ] <> Map.fromList [(v,v) | v <- vs]
 
 -- This function computes hashes for data and effect declarations, and
 -- also returns a function for resolving strings to (Reference, ConstructorId)

unison-src/transcripts/fix4415.md

@@ -0,0 +1,5 @@
+
+```unison
+unique type Foo = Foo
+unique type sub.Foo =
+```

unison-src/transcripts/fix4415.output.md

@@ -0,0 +1,18 @@
+
+```unison
+unique type Foo = Foo
+unique type sub.Foo =
+```
+
+```ucm
+
+  I found and typechecked these definitions in scratch.u. If you
+  do an `add` or `update`, here's how your codebase would
+  change:
+  
+    ⍟ These new definitions are ok to `add`:
+    
+      unique type Foo
+      unique type sub.Foo
+
+```