Apply perf optimization: don't call callback unless there are changes

unisonweb · Aug 31, 2023 · fee4277 · fee4277
1 parent 524700d
commit fee4277
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/parser-typechecker/src/U/Codebase/Branch/Diff.hs b/parser-typechecker/src/U/Codebase/Branch/Diff.hs
@@ -222,11 +222,10 @@ streamNameChanges namePrefix (TreeDiff (DefinitionDiffs {termDiffs, typeDiffs} :
             let name = appendName ns
              in (listifyNames name $ adds diff, listifyNames name $ removals diff)
   let nameChanges = NameChanges {termNameAdds, termNameRemovals, typeNameAdds, typeNameRemovals}
-  acc <- f namePrefix nameChanges
-  -- acc <-
-  --   if nameChanges == mempty
-  --     then pure mempty
-  --     else f namePrefix nameChanges
+  acc <-
+    if nameChanges == mempty
+      then pure mempty
+      else f namePrefix nameChanges
   childAcc <-
     children
       & ifoldMapM