Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug "uh oh" should not be tagged as a Doc or a Test #4407

Closed
aryairani opened this issue Nov 20, 2023 · 2 comments · Fixed by #4408
Closed

bug "uh oh" should not be tagged as a Doc or a Test #4407

aryairani opened this issue Nov 20, 2023 · 2 comments · Fixed by #4408
Assignees

Comments

@aryairani
Copy link
Contributor

Currently it is probably both, with preference given to Doc.
image

See getTermTag in Backend.hs; we don't want a subtype test here. I think == will work, but I haven't tried it.

cc @hojberg

@ChrisPenner
Copy link
Contributor

I'll have to take time to test it yet, but whipped up the fix quick before I forget: #4408

@ceedubs
Copy link
Contributor

ceedubs commented Nov 20, 2023

Something subtle:

For the purposes of io.test, '{} [Test.Result], '{IO} [Test.Result], '{Exception} [Test.Result], and '{Exception, IO} [Test.Result] should probably all match. That is, it's probably fine do an exact match for the Test.Result, but you do probably want subtyping for the abilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants