Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exact match on term types when determining whether doc or test. #4408

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Nov 20, 2023

Overview

Fixes #4407

Don't do subtype matching for docs and terms or we'll match fully polymorphic terms.

Docs and types don't have type variables anyways, so we can do a full equality check.

Implementation notes

Switch to an isEqual rather than isSubtype check for whether terms are docs or tests.

Testing

  • Tested locally

@aryairani
Copy link
Contributor

Sweet!

@ChrisPenner ChrisPenner marked this pull request as ready for review January 11, 2024 21:20
@ChrisPenner ChrisPenner requested a review from aryairani January 11, 2024 22:30
@aryairani aryairani merged commit 6f2a943 into trunk Jan 12, 2024
7 checks passed
@aryairani aryairani deleted the cp/type-tag-exact-match branch January 12, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug "uh oh" should not be tagged as a Doc or a Test
2 participants