Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exports for Share migration to Postgres #4338

Merged
merged 8 commits into from
Jan 12, 2024
Merged

Exports for Share migration to Postgres #4338

merged 8 commits into from
Jan 12, 2024

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Oct 3, 2023 •
edited
Loading

See https://github.com/unisoncomputing/enlil/pull/338 for background and justification.

  • Exports serialization combinators for encoding/decoding individual component elements (since Share stores component elements separately)
  • Exports combinators for hoisting the name search so we can lift it into different monads when necessary.
  • Adds extraMapM for mapping terms with effects.

@ChrisPenner ChrisPenner marked this pull request as ready for review January 10, 2024 23:18
@ChrisPenner ChrisPenner requested a review from aryairani January 10, 2024 23:20
@ChrisPenner ChrisPenner marked this pull request as draft January 10, 2024 23:28
@ChrisPenner ChrisPenner marked this pull request as ready for review January 11, 2024 17:30
@ChrisPenner ChrisPenner self-assigned this Jan 11, 2024
@aryairani aryairani merged commit 8e78af3 into trunk Jan 12, 2024
7 checks passed
@aryairani aryairani deleted the pg/causals branch January 12, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryairani aryairani aryairani approved these changes

Assignees

@ChrisPenner ChrisPenner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisPenner @aryairani