JIT: Added Code.lookup function and various supporting code changes
#4339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a code cache in the unison/data module that associates the
term links with their intermediate code.
- Added a macro for defining termlinks for builtin functions, for
builtins that are implemented direclty in scheme.
- Declared termlinks for directly implemented builtins
- Nullary unison data constructors have been changed to not be
procedures, so various replacements like:
(unison-optional-none) ==> unison-optional-none
- Implemented code lookup builtin/primop
- Makes sure the code that is added to the cache as part of the test can be looked back up, and is equal to what was added to the cache.
pchiusano
approved these changes
Oct 5, 2023
Includes an implementation of Link.Term.toText
pchiusano
changed the title
Code.lookup function and various supporting code changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains updates related to looking up code at runtime
(unison-optional-none) ==> unison-optional-noneI'll add some tests that look up statically generated code. Right now the tests only look up code that is added to the cache dynamically, and that's an almost completely different code path.