quick fix for delete.type #4315 for next steps #4342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
old pr for reference: #4316 |
aryairani
reviewed
Oct 10, 2023
| @@ -727,22 +727,22 @@ deleteGen suffix target mkTarget = | |||
| ) | |||
|
|
|||
| delete :: InputPattern | |||
| delete = deleteGen Nothing "term or type" (DeleteTarget'TermOrType DeleteOutput'NoDiff) | |||
| delete = deleteGen Nothing exactDefinitionTermQueryArg "term or type" (DeleteTarget'TermOrType DeleteOutput'NoDiff) | |||
There was a problem hiding this comment.
This one maybe needs a TermOrTypeQueryArg
aryairani
approved these changes
Oct 10, 2023
|
You'll need to |
ChrisPenner
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
More of a temp solution to negate the issue. See #4315 for the bigger/fuller fix
Test coverage
Manual testing