Add missing spaces to pull explanation

[JohanWinther]

Overview

Adds missing spaces to the explanation of all the pull commands.

Before:

@unison/base/main> ? pull

  pull (or pull.silent)
  The`pull`command merges a remote namespace into a local namespacewithout listing the merged entities

After:

Test coverage

No changes to tests needed.

[aryairani]

Hey @JohanWinther, thanks for noticing this and putting together a PR!

Probably no changes to tests needed.

For this sort of thing, a screenshot or paste like what you have in the description is sufficient for testing.

Screenshot is better though — because I think if you doublecheck you will find that this PR doesn't produce exactly the output you have in the "After" section.

The bug you found is pretty subtle:
P.wrap is not supposed to require spaces, so it was odd that you needed them. In fact, it deletes spaces and adds its own, so it was odd that adding spaces would help! What's actually happening is that P.wrap is only being applied to the first argument, "The", and so it does in fact delete the space that you tried to insert there, but fails to set up the spaces through the rest of the message.

The correct fix is change P.wrap to P.wrap $, or else put all of the text in parens. And then remove the extra spaces like it was originally. Do you wanna do this?

[JohanWinther]

Hey @JohanWinther, thanks for noticing this and putting together a PR!

Probably no changes to tests needed.

For this sort of thing, a screenshot or paste like what you have in the description is sufficient for testing.

Screenshot is better though — because I think if you doublecheck you will find that this PR doesn't produce exactly the output you have in the "After" section.

Yes, screenshot is better because I didn't actually paste in what the new version would output, I added what should be the result. I was too lazy to actually pull down the repo and figure out how to compile it and test it out, since I thought the change was trivial. Thanks for being diligent :)

The bug you found is pretty subtle: P.wrap is not supposed to require spaces, so it was odd that you needed them. In fact, it deletes spaces and adds its own, so it was odd that adding spaces would help! What's actually happening is that P.wrap is only being applied to the first argument, "The", and so it does in fact delete the space that you tried to insert there, but fails to set up the spaces through the rest of the message.

I sort of understood that P.wrap should do this from the other uses of the function in the file, but couldn't really figure it out so I kind of ignored it.

The correct fix is change P.wrap to P.wrap $, or else put all of the text in parens. And then remove the extra spaces like it was originally. Do you wanna do this?

I will try to do these changes and actually compile and test locally. Thanks for the explanation 👍

[JohanWinther]

@aryairani I've pushed the changes and updated the description to include a screenshot

[aryairani]

Awesome!

[aryairani]

Oh, @JohanWinther would you also add yourself to CONTRIBUTORS.markdown to acknowledge the license.

[JohanWinther]

@aryairani Done! Sorry for the long wait, I missed the notification.

[aryairani]

No worries, thanks!

[aryairani]

Oh... I thought I had queued it to merge.