Use minimal suffix that's distinct from local var names #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchiusano
added
the
ready-to-merge
|
@pchiusano Thanks for adding the original regression transcript, always makes testing these things so much easier :) |
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes: #4480
When disambiguating suffixified names against local variables, rather than just using the FQN we find the smallest viable suffix. This should JustWork™ on Share too.
Implementation notes
Starting with the suffixified name, keep adding segments until we find a name that doesn't conflict with anything locally defined. 99.9% of the time this'll just be a single segment, but it'll fall back all the way to the FQN if necessary.
Interesting/controversial decisions
Nah
Test coverage
See the updates to the regression test for proof :)