Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update UpdateIncompleteConstructorSet message #4503

Merged
merged 3 commits into from
Dec 13, 2023
Merged

update UpdateIncompleteConstructorSet message #4503

merged 3 commits into from
Dec 13, 2023

Conversation

aryairani
Copy link
Contributor

@aryairani aryairani commented Dec 13, 2023

Changes the phrasing of the UpdateIncompleteConstructorSet message from

  I couldn't complete the update because I couldn't find 1
  constructor(s) for Foo where I expected to. I found: []
  
  You can use `view Foo` and
  `alias.term <hash> Foo.<ConstructorName>` to give names to
  each constructor, and then try again.

to

  I couldn't complete the update because the type Foo has
  unnamed constructors. (I currently need each constructor to
  have a name somewhere under the type name.)
  
  You can use `view Foo` and
  `alias.term <hash> Foo.<ConstructorName>` to give names to
  each constructor, and then try the update again.

The output will say update or upgrade depending on the command used.

The output will no longer say which constructors it did find; but the information is still in the OutputMessage in case we change our minds.

closes #4491

@aryairani aryairani merged commit 309517c into trunk Dec 13, 2023
7 checks passed
@aryairani aryairani deleted the fix/4491 branch December 13, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failure to upgrade "I couldn't find 1 constructor(s)"
2 participants