Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update the name of the pre-release build #4508

Merged
merged 1 commit into from
Dec 19, 2023
Merged

update the name of the pre-release build #4508

merged 1 commit into from
Dec 19, 2023

Conversation

aryairani
Copy link
Contributor

per https://unisonlanguage.slack.com/archives/CLUNF0J5S/p1702495233966029 which will be accessible until mid-March

update the name of the pre-release build
d1d9e99 
per https://unisonlanguage.slack.com/archives/CLUNF0J5S/p1702495233966029
which will probably not be accessible information when you read this
@aryairani aryairani requested a review from ceedubs December 13, 2023 21:02
ceedubs
ceedubs approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@ceedubs ceedubs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Is there anywhere else that we'd need to update documentation?

@aryairani
Copy link
Contributor Author

aryairani commented Dec 14, 2023 •
edited
Loading

Looks good to me. Is there anywhere else that we'd need to update documentation?
Good question — @rlmark Do you know?

This PR is about changing the nomenclature and url for UCM binaries that are built off of trunk
from "latest" / https://github.com/unisonweb/unison/archive/refs/tags/latest.zip / https://github.com/unisonweb/unison/releases/download/latest/ucm-windows.zip / etc.

to "trunk" / https://github.com/unisonweb/unison/archive/refs/tags/trunk.zip / https://github.com/unisonweb/unison/releases/download/trunk/ucm-windows.zip / etc.

@aryairani aryairani requested a review from rlmark December 14, 2023 01:58
@aryairani
Copy link
Contributor Author

this may require a corresponding change to the homebrew formula for —head. is there one for nix too?

@ceedubs
Copy link
Contributor

ceedubs commented Dec 15, 2023

this may require a corresponding change to the homebrew formula for —head. is there one for nix too?

No, not with the way that the derivation is currently set up.

@rlmark
Copy link
Contributor

rlmark commented Dec 19, 2023

You should be good! We don't link to the pre-release builds for the installs page, only the official latest ones!

@aryairani aryairani merged commit 715cf10 into trunk Dec 19, 2023
7 checks passed
@aryairani aryairani deleted the rename-prerelease branch December 19, 2023 22:04
@aryairani aryairani mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlmark rlmark rlmark approved these changes

@ceedubs ceedubs ceedubs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aryairani @ceedubs @rlmark