Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make namespace.dependencies ignore lib #4509

Merged
merged 3 commits into from
Dec 14, 2023
Merged

make namespace.dependencies ignore lib #4509

merged 3 commits into from
Dec 14, 2023

Conversation

mitchellwrosen
Copy link
Member

@mitchellwrosen mitchellwrosen commented Dec 14, 2023 •
edited
Loading

Overview

This PR amends namespace.dependencies in two ways:

  • We don't crawl through lib to report its "external" (nameless) dependencies
  • We don't bother reporting anything to do with metadata anymore

Fixes #4487
Fixes #4488

@mitchellwrosen mitchellwrosen marked this pull request as ready for review December 14, 2023 18:59
@aryairani aryairani merged commit 3d57a2d into trunk Dec 14, 2023
7 checks passed
@aryairani aryairani deleted the 23-12-13-namespace-dependencies-is-slow branch December 14, 2023 20:41
@aryairani aryairani mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryairani aryairani aryairani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

namespace.dependencies can be slow namespace.dependencies should ignore lib
2 participants
@mitchellwrosen @aryairani