Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSP startup time speedup and CWD fix #4647

Merged
merged 2 commits into from
Jan 30, 2024
Merged

LSP startup time speedup and CWD fix #4647

merged 2 commits into from
Jan 30, 2024

Conversation

ChrisPenner
Copy link
Contributor

Overview

  • This applies the UCM start-up time fix from regular UCM to the LSP
  • The LSP will no longer report incorrect errors before the server is loaded, it'll just wait until it's ready.
  • Fixes an issue where the LSP wasn't always being set to the correct 'current path'

Implementation notes

Like the UCM speedup, this skips loading the entire root-branch and instead just loads the current branch, which speeds things up a lot.

I swapped TVars which were being initialized with empty values, to TMVars that aren't filled until the LSP is loaded to avoid reporting incorrect errors.

Interesting/controversial decisions

Nah, straight-forward improvement.

Test coverage

I tried it out, we can dogfood on trunk for a bit.

@ChrisPenner ChrisPenner marked this pull request as ready for review January 29, 2024 19:44
@aryairani aryairani merged commit 44e2c21 into trunk Jan 30, 2024
7 checks passed
@aryairani aryairani deleted the cp/lsp-startup-time branch January 30, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants