LSP startup time speedup and CWD fix #4647
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Implementation notes
Like the UCM speedup, this skips loading the entire root-branch and instead just loads the current branch, which speeds things up a lot.
I swapped TVars which were being initialized with empty values, to TMVars that aren't filled until the LSP is loaded to avoid reporting incorrect errors.
Interesting/controversial decisions
Nah, straight-forward improvement.
Test coverage
I tried it out, we can dogfood on trunk for a bit.