Speed up docs.to-html by not using root-branch #4650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When investigating a bug for Rebecca earlier today I saw we're loading the root branch unnecessarily in
docs.to-htmland it was a trivial fix. Should speed up the command and also means you don't have to wait for the root branch to load into memory.Implementation notes
Rather than loading the root branch, then getting a sub-branch; just load the sub-branch directly. It'll get pulled from the cache if it's already loaded elsewhere in UCM.
Test coverage
None, it's a pretty trivial change.