Add parens to annotation of lexed symboly segments #4689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #4682
Fixes #4676
The annotations for operators like
(++)
only span the++
, so the brackets get duplicated.Fixed this by just including the span of the parens into the lexer token for symboly names like this.
Implementation notes
Include the span of the parens in the lexer tokens for symboly names.
Test coverage
Added cases to the formatter transcript