Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac arm builds #5390

Merged
merged 3 commits into from
Oct 8, 2024
Merged

mac arm builds #5390

merged 3 commits into from
Oct 8, 2024

Conversation

aryairani
Copy link
Contributor

Overview

Add some CI support for building on multiple platforms besides x86_64.

Adds a new runner for releases, and changes the filenames of release packages to include an architecture tag:

  • ucm-linux-x64.tar.gz
  • ucm-macos-arm64.tar.gz
  • ucm-macos-x64.tar.gz
  • ucm-windows-x64.zip

Closes #3045

Interesting/controversial decisions

Wasn't sure whether mac arm and x64 both need to be run in CI or just during releases; as of now, it's just x64 in CI, like before.

Test coverage

I ran it here: https://github.com/unisonweb/unison/releases/tag/mac-arm-build-build

Loose ends

@aryairani aryairani requested a review from a team as a code owner October 4, 2024 14:41
@aryairani
Copy link
Contributor Author

aryairani commented Oct 4, 2024

When this gets merged, scripts that try to download the latest release or the nightly release will need to update the file name they're looking for, to include the architecture per the bullets in the description cc @ceedubs @rlmark

@kubukoz
Copy link

kubukoz commented Oct 4, 2024

When this gets merged, scripts that try to download the latest release or the nightly release will need to update the file name they're looking for, to include the architecture per the bullets in the description cc @ceedubs @rlmark

This will also affect Nixpkgs: https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/compilers/unison/default.nix

@aryairani aryairani merged commit 0018203 into trunk Oct 8, 2024
46 checks passed
@aryairani aryairani deleted the topic/mac-arm-build branch October 8, 2024 16:06
@kubukoz
Copy link

kubukoz commented Dec 2, 2024

FYI I finally had a change to give this a try (for advent of code), and I feel like it's much snappier!

Nixpkgs PR: NixOS/nixpkgs#360905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aarch64 support
2 participants