remove quadratic limitation on counting quotes #5599
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation called
Text.breakOnAll
repeatedly, which could be slow, so it was capped at 10 quotes. The new implementation instead just callsText.group
once instead.The PR could use a before and after check with a string with more than 10 consecutive
"
in it, and we should see that the rendering is improved with the PR. Existing tests show"""
correctly being escaped as""""
though, and since the PR removes the reference to10
, there isn't actually anything special about 10 going forward.