Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App pack build service integration #31

Merged
merged 5 commits into from
Aug 26, 2024

Conversation

mike-gangl
Copy link
Contributor

Purpose

  • integrate app-pack-gen-client libraries (libs/app-package-build-client) into unity-py

Proposed Changes

  • [ADD] unity-sds-apgs-client requirement
  • [ADD] code for calling the build commands into ApplicationService.py
  • [ADD] tests for mocking execution
  • [CHANGED] - changelog, pyproject version (0.6.0)

Testing

@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10381948788

Details

  • 36 of 64 (56.25%) changed or added relevant lines in 2 files are covered.
  • 297 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+9.9%) to 49.691%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libs/unity-py/unity_sds_client/services/application_service.py 33 61 54.1%
Files with Coverage Reduction New Missed Lines %
libs/app-package-build-client/unity_sds_apgs_client/models/ads_acb_mcp_clone_get200_response.py 5 64.71%
libs/app-package-build-client/unity_sds_apgs_client/api/default_api.py 24 45.1%
libs/app-package-build-client/unity_sds_apgs_client/exceptions.py 25 32.22%
libs/app-package-build-client/unity_sds_apgs_client/rest.py 34 31.25%
libs/app-package-build-client/unity_sds_apgs_client/configuration.py 52 63.87%
libs/app-package-build-client/unity_sds_apgs_client/api_client.py 157 22.12%
Totals Coverage Status
Change from base Build 10253529857: 9.9%
Covered Lines: 804
Relevant Lines: 1618

💛 - Coveralls

Copy link
Contributor

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works.
needs a lot of help in terms of transparency of status

@mike-gangl mike-gangl merged commit 213b2d0 into main Aug 26, 2024
8 checks passed
@mike-gangl mike-gangl deleted the app-pack-build-service-integration branch August 26, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants