Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/unity sds client update health service #43

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

anilnatha
Copy link
Contributor

Purpose

This PR addresses the following changes:

Proposed Changes

  • [CHANGE] The Health JSON schema definition
  • [CHANGE] Update the unity-sds-client Health Service so that it fetch health data from the health endpoint that has been recently migrated to AWS API GW
  • [CHANGE] The landingPageUrl information is included in the health status report.
  • [CHANGE] Unit tests to coincide with changes listed above.

Issues

unity-sds/unity-py#91

@rtapella I can't comment or transfer the above ticket to the monorepo repository because the unity-py repo has been archvied.

Testing

Successfully ran unit tests to confirm above changes are working as expected against our Unity-Venue-Dev account

@anilnatha
Copy link
Contributor Author

Interesting, three of the jobs failed when the PR was created, no changes made to the PR, reran the three failed jobs and they all passed. 😕

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant