Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

Add health service #90

Merged
merged 15 commits into from
Jul 3, 2024
Merged

Add health service #90

merged 15 commits into from
Jul 3, 2024

Conversation

anilnatha
Copy link
Collaborator

Purpose

Initial implementation of a health service to convey the health state of the system. This implementation is using a stubbed in set of data until we can integrate an API call to fetch the health data for a given project/venue when the API endpoint is implemented.

Proposed Changes

  • Added Health Service that provides features to fetch and print the health state of the system.
  • Changed printing of unity objects so that they include the health status report.
  • Updated changelog and version number of unity-py, currently marked as 'unreleased' in CHANGELOG.

Issues

Testing

  • Created initial unit tests to ensure fetching, report generation, and printing of health report are functional

… To view health status information, the health status information is included when a user prints an instantiated unity object.
…alth statuses are printed to account for service's historical health status information.
…n be reused in multiple places to improve consistency of the health status report.
@anilnatha anilnatha requested a review from rtapella June 18, 2024 20:23
Copy link
Collaborator

@rtapella rtapella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix linting. other than that, ok

@anilnatha
Copy link
Collaborator Author

Thanks @rtapella, yup, I'm working on the linting right now.

@anilnatha
Copy link
Collaborator Author

@mike-gangl I fixed the linting errors that were being reported in the checks; however, now we're having an issue with coveralls and all it reports is:

🔍 Detected coverage file: .coverage
🚨 Nothing to report
Error: Process completed with exit code 1.

Have you come across this issue in the past?

@coveralls
Copy link

Coverage Status

coverage: 52.801% (-34.8%) from 87.575%
when pulling c14bce0 on feature/add-health-service
into 44488b0 on develop.

@coveralls
Copy link

Coverage Status

coverage: 52.801% (-34.8%) from 87.575%
when pulling d2b6275 on feature/add-health-service
into 44488b0 on develop.

@mike-gangl
Copy link
Contributor

not sure why the coverage dropped to 50%, but that's something we'll want to increase coverage on in the future.

@mike-gangl
Copy link
Contributor

You're free to merge this check in now. i had to update the version of the coverage, but also change the coverage report being generated by pytest. ther was something "under the good" that was causing the coverage formatting to be invalid.

@coveralls
Copy link

Coverage Status

coverage: 52.801% (-34.8%) from 87.575%
when pulling b37a45b on feature/add-health-service
into 44488b0 on develop.

@mike-gangl mike-gangl merged commit 99568b4 into develop Jul 3, 2024
7 of 8 checks passed
@mike-gangl mike-gangl deleted the feature/add-health-service branch July 3, 2024 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants