Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing the cwl_dag.py to accept a URL #204

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fixing the cwl_dag.py to accept a URL #204

merged 1 commit into from
Sep 18, 2024

Conversation

LucaCinquini
Copy link
Collaborator

Purpose

  • This PR fixes a bug in the cwl_dag.py which was not working any more when providing the input parameters as a URL

Proposed Changes

  • [FIX] Handling of parameter "cwl_args" in cwl_dag.py

Testing

  • Verified that with this version I was able to submit and run the cwl_dag.py both with the URL of a YAML file, and with a JSON blob. I also successfully used the latest OGC API to submit the example job request.

drewm-swe
drewm-swe approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@drewm-swe drewm-swe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@drewm-swe drewm-swe merged commit 0d8bca8 into develop Sep 18, 2024
2 checks passed
@drewm-swe drewm-swe deleted the fix-cwl-dag branch September 18, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewm-swe drewm-swe drewm-swe approved these changes

@nikki-t nikki-t Awaiting requested review from nikki-t

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucaCinquini @drewm-swe