Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ALB lockdown configurations #211

Merged
merged 3 commits into from
Sep 25, 2024
Merged

Fix ALB lockdown configurations #211

merged 3 commits into from
Sep 25, 2024

Conversation

jpl-btlunsfo
Copy link
Collaborator

@jpl-btlunsfo jpl-btlunsfo commented Sep 23, 2024

Purpose

Proposed Changes

  • ADD Additional security group for internal connections
  • ADD Additional k8s-driven ingress for internal-only/private-subnet connections
  • CHANGE internal venue-services proxy and healthcheck SSM parameters to reference internal endpoints

Issues

Testing

@jpl-btlunsfo
Copy link
Collaborator Author

I note that, a couple times while testing this, the SSM parameter for the proxy-configuration can end up with the wrong/public ALB information encoded, even though the terraform config for that explicitly references the internal ALB ingress...

I'm unsure if there's a propagation/timing issue there (on retriggering the venue-proxy lambda everything is updated correctly)

Copy link
Collaborator

@LucaCinquini LucaCinquini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked for me on a couple of installations.

@LucaCinquini LucaCinquini merged commit 95dad09 into develop Sep 25, 2024
2 checks passed
@LucaCinquini LucaCinquini deleted the 429-fix-alb-lockdown branch September 25, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants