-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
126 airflow cognito integration #226
base: develop
Are you sure you want to change the base?
Conversation
Pending items:
|
I tested this branch on a custom "unity-luca-1" deployment and it worked - great job! |
Just a note regarding the venue-services proxy; I believe you'll need to modify the They've got
|
Modify Terraform to query SSM parameter store for parameter that contain Cognito app client data. Can confirm that sensitive data is not shown when running Terraform plan. Terraform will perform the following actions:
# module.unity-sps-airflow.helm_release.airflow will be updated in-place
~ resource "helm_release" "airflow" {
id = "airflow"
name = "airflow"
~ values = [
# Warning: this attribute value will be marked as sensitive and will not
# display in UI output after applying this change. The value is unchanged.
~ (sensitive value),
]
# (27 unchanged attributes hidden)
# (2 unchanged blocks hidden)
} Waiting on how the client id and client secret will be stored in SSM parameter store and whether it falls under SPS to store these values. |
Purpose
Proposed Changes
webserver_config.py
.Issues
Testing
Implemented locally and then deployed to
unity-venue-dev
for testing:Confirmed hand off to Cognito for user authentication
Confirmed log into Airflow UI and user role