-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
220 - Define stage in, process, stage out tasks in entrypoint #240
Conversation
I updated the code to account for a new modular CWL Dag container image:
I think once we merge, we will want to:
@LucaCinquini - I think this is ready to be merged but we will need to coordinate the above steps. Let me know what you think! |
- Restructure entrypoint to handle file i/o between tasks - Update DAG to pass in stage out arguments and STAC JSON - Remove entrypoint utility script
Updated for the following changes:
Tested in @LucaCinquini - I think this may be ready to merge but take a look and let me know if you have any feedback/want to see any changes, thanks! (We may still want to build the modular Docker container image to test that the Docker build script is working for the CWL DAG modular package) |
Successfully tested after merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nikki-t : great work but I do have a few questions:
- Can the value of DS_S3_BUCKET_PARAM be replaced with something more general? (i.e. remove "unity-nikki-1"). I think Galen and Nga have settled on an approved key for this SSM parameter.
- Have you talked to Nga about changes to the stage in and stage out workflows?
- It also occurred to me that we could build one single image for the sps-docker container, and override the entrypoint that is invoked by the cwl_dag_modular.py
I will approve and merge this PR for now but we might want to consider implementing point 3) above after the holidays.
Purpose
Notes to consider:
Proposed Changes
Issues
Testing
Deployed to
unity-venue-dev
for testing:Stage-In, Processing, Stage-Out logs