Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying the UNITY_OUTPUT_DATA_BUCKET to recognize deployment & venue #93

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jpl-btlunsfo
Copy link
Collaborator

@jpl-btlunsfo jpl-btlunsfo commented May 16, 2024

Purpose

  • Updating the non-venue-independent references in sbg_L1_to_L2_e2e_cwl_step_by_step_dag.py

Proposed Changes

  • CHANGE the UNITY_OUTPUT_DATA_BUCKET variable (path) to include deployment name, venue, and counter

Issues

Testing

  • manually tested in one-off airflow installation
Screenshot 2024-06-13 at 3 05 48 PM

@jpl-btlunsfo jpl-btlunsfo self-assigned this May 16, 2024
@jpl-btlunsfo jpl-btlunsfo marked this pull request as ready for review June 13, 2024 22:06
@jpl-btlunsfo
Copy link
Collaborator Author

Just to note, the DAG fails pretty quickly if the UNITY_OUTPUT_DATA_BUCKET ssm path doesn't exist. Should creation of that parameter also be a part of this PR?

After talking with Galen I went with the format /unity/ds/data/bucket/{deployment_name}/{venue}-{counter}/primary-data-bucket (ex /unity/ds/data/bucket/btl/test-b2d6/primary-data-bucket)

@LucaCinquini
Copy link
Collaborator

Hi Brad, we should probably not merge this PR until the DAG will succeed. I think this involves:

o Making sure the output data bucket exists. Who is creating this, us or DS?
o Also creating the proper SSM parameter

You can work on #2 above, I will raise the question about #1 with the team

@LucaCinquini LucaCinquini changed the title Modifying to recognized deployment & venue Modifying the UNITY_OUTPUT_DATA_BUCKET to recognize deployment & venue Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants