Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only install fzf when it isn't already in $PATH #98

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Only install fzf when it isn't already in $PATH #98

merged 1 commit into from
Mar 6, 2024

Conversation

unixorn
Copy link
Owner

@unixorn unixorn commented Mar 5, 2024

Description

Only install fzf when it isn't already in $PATH. Fixes #87, #44

Checklist

  • All new and existing tests pass.
  • Rather than adding functions to fzf-zsh-plugin.zsh, I have created standalone scripts in bin so they can be used by non-ZSH users too.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an ok exception)
  • Scripts are marked executable
  • Scripts do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that the link(s) in my PR are valid.
  • I have read the CONTRIBUTING document.

License Acceptance

  • This repository is Apache version 2.0 licensed (some scripts may have alternate licensing inline in their code) and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

@unixorn unixorn added the bug Something isn't working label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ COPYPASTE jscpd yes no 1.06s
⚠️ REPOSITORY checkov yes 2 12.26s
✅ REPOSITORY devskim yes no 1.47s
✅ REPOSITORY dustilock yes no 0.0s
✅ REPOSITORY gitleaks yes no 0.19s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 11.88s
⚠️ REPOSITORY kics yes 1 2.23s
✅ REPOSITORY secretlint yes no 1.05s
✅ REPOSITORY syft yes no 0.23s
✅ REPOSITORY trivy yes no 5.48s
✅ REPOSITORY trivy-sbom yes no 3.36s
✅ REPOSITORY trufflehog yes no 10.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@unixorn unixorn merged commit 502e367 into main Mar 6, 2024
5 checks passed
@unixorn unixorn deleted the fix-87 branch March 6, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin installing fzf regardless of presence in $PATH
1 participant