Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed hardcoded credentials in test_discoverable #157

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

ha-enthus1ast
Copy link
Contributor

Description

Removes hardcoded credentials for tests/test_discoverable.py causing megalinter to fail

Fixes #156

License Acceptance

  • This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

  • Add/update a helper script
  • Add/update link to an external resource like a blog post or video
  • Bug fix
  • New feature
  • Test updates
  • Text cleanups/updates

Checklist

  • I have read the CONTRIBUTING document.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts added/updated in this PR are all marked executable.
  • Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that any links added or updated in my PR are valid.

@ha-enthus1ast
Copy link
Contributor Author

ha-enthus1ast commented Dec 19, 2023

@unixorn This only addresses the issue in the current rev. of the file. In order to fix this issue completely one would have to scrub the secrets from history. In my opinion it is not worth the hassle, since the credentials aren't actually secret in any way. I suggest ignoring this file, at least for now.

Signed-off-by: ha-enthus1ast <[email protected]>
Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@unixorn unixorn merged commit 9507ce2 into unixorn:main Dec 19, 2023
3 of 4 checks passed
@unixorn
Copy link
Owner

unixorn commented Dec 19, 2023

Thanks for the assist!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Megalinter fails for tests/test_discoverable.py
2 participants