Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed set_state with last_update #294

Merged
merged 5 commits into from
Dec 27, 2024
Merged

fixed set_state with last_update #294

merged 5 commits into from
Dec 27, 2024

Conversation

unl0ck
Copy link
Contributor

@unl0ck unl0ck commented Dec 26, 2024

Table of Contents generated with DocToc

Description

License Acceptance

  • This repository is Apache version 2.0 licensed and by making this PR, I am contributing my changes to the repository under the terms of the Apache 2 license.

Type of changes

  • Add/update a helper script
  • Add/update link to an external resource like a blog post or video
  • Bug fix
  • New feature
  • Test updates
  • Text cleanups/updates

Checklist

  • I have read the CONTRIBUTING document.
  • All new and existing tests pass.
  • Any scripts added use #!/usr/bin/env interpreter instead of potentially platform-specific direct paths (#!/bin/sh is an allowed exception)
  • Scripts added/updated in this PR are all marked executable.
  • Scripts added/updated in this PR do not have a language file extension unless they are meant to be sourced and not run standalone. No one should have to know if a script was written in bash, python, ruby or whatever. Not including file extensions makes it easier to rewrite the script in another language later without having to change every reference to the previous version.
  • I have confirmed that any links added or updated in my PR are valid.

Copy link
Owner

@unixorn unixorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding tests

@@ -740,6 +740,7 @@ def _state_helper(
topic = self.state_topic
if last_reset:
state = {"state": state, "last_reset": last_reset}
state = json.dumps(state)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@unixorn unixorn merged commit d826731 into unixorn:main Dec 27, 2024
3 of 5 checks passed
@unixorn unixorn mentioned this pull request Dec 27, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants