feat: add tar provider, more tests, adjust vitest config #86
Conversation
| @@ -2,8 +2,12 @@ import { defineConfig } from "vitest/config"; | |||
|
|
|||
| export default defineConfig({ | |||
| test: { | |||
| exclude: [ | |||
| "**/node_modules/**", | |||
| "./test/.tmp/**" | |||
There was a problem hiding this comment.
Added .tmp directory to exclusions to get rid of skipped tests in the the coverage report
| return <TarInfo>{ | ||
| url: m.url, | ||
| name: m.name || "", | ||
| version: m.version || "", |
There was a problem hiding this comment.
I think that version is not used anywhere if both name and version provided. I would just keep only name
|
When will you be in master? |
@pi0 kind reminder to review. Let me know if any adjustments are needed |
|
Hi dear @alex-key thanks for working on this PR and sorry it got stalled for a while. I have worked on a slightly different approach to support generic HTTP(s) sources as either JSON provider or direct tar provider (#129) As for tests, they are really nice additions. There are couple of merge conflicts now wasn't sure if you prefer to still pick it to rebase or not but moved to the issue ##130 please ping to assign if you still like to help on improving test coverage! |
Should resolve #10
@pi0 I had to change proposed pattern to replace
&=versionwith#version. Ampersand (&) could be evaluated by most terminals as next command if you do not wrap in quotes. So I propose to use[url]#name=[name]#version=[version].Though I am not sure if
versionis really needed and useful. See my comment in the diff.