Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update constructor harness to support workerd #119

Merged
merged 1 commit into from
May 8, 2024
Merged

Conversation

jasnell
Copy link
Collaborator

@jasnell jasnell commented Apr 30, 2024

workerd API constructors that are missing arguments start with the "Failed to construct..." prefix.

πŸ”— Linked issue

#76

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Improve detection of API constructors supported by workerd.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

workerd API constructors that are missing arguments start with the "Failed to construct..." prefix.
@ascorbic ascorbic enabled auto-merge (squash) April 30, 2024 09:16
@ascorbic
Copy link
Collaborator

I'm not sure why the CF pages deploy hasn't happened, but it's a required check

@jasnell
Copy link
Collaborator Author

jasnell commented May 6, 2024

Any ideas on how we move this forward?

@ascorbic ascorbic merged commit b799356 into unjs:main May 8, 2024
3 checks passed
@pi0
Copy link
Member

pi0 commented May 8, 2024

@ascorbic not sure either checking from dashboard it was not triggered at all. disabled required check to unblock this.

@queengooborg
Copy link
Collaborator

Just pulled this change upstream into the collector! openwebdocs/mdn-bcd-collector#1453

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants