Deabstract savable interface #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
deab-savable-inh
branch
from
a90dcff to
845a7d6
Compare
create_state refact Hashable initialized + parameters passed to Hashable Fix pre-commit errors
For the auto_persist attributes, the fn auto_save will take care of save the state
- stepper de-abstract - remove ContextMixin - Stepper all using recreate_from
- remove persist_config flag of savable
unkcpz
force-pushed
the
deab-savable-inh
branch
from
1315e38 to
0a3b65e
Compare
unkcpz
force-pushed
the
deab-savable-inh
branch
from
4fae0db to
76c887f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The refactoring is targeting to make all savable thing to not necessary inherit from
Savablebut just need to have the implementation ofsaveandrecreate_frommethod which required by theSavableprotocol. It then give all the independency for implementing/experimenting the save/load round trip for each savable type with different ways of serialization.