Creating boards from wood in a building #124

TheSephyr · 2024-11-10T14:27:04Z

Removing the production and now buildings are added to the factory. Buildings now keep information about the current workers and the amount of produces goods.

theludovyc · 2024-11-11T10:31:36Z

theLudovyc/Building/Building.gd

@@ -10,6 +10,8 @@ signal selected(type)
 var event_bus: EventBus

 var is_selected := false
+var current_ticks: int = 0


Hello 👋

I made an architecture like MVC, with backend and frontend. The class building2d is only here for the frontend part. Please do not add backend logic in here 😊

This is why the event_bus exist also.

https://en.wikipedia.org/wiki/Model%E2%80%93view%E2%80%93controller

Adjusted the code in order to fit the MVC pattern.

theludovyc · 2024-11-11T10:35:10Z

theLudovyc/Building/Buildings.gd

 	Ids.Warehouse: {Datas.Name: &"Warehouse", Datas.Type: Types.Warehouse},
 	Ids.Tent:
 	{
 		Datas.Name: &"Tent",
 		Datas.Type: Types.Residential,
-		Datas.Cost: [[Resources.Types.Wood, 1], [Resources.Types.Textile, 1]],
+		Datas.Cost: [[Resources.Types.Board, 1], [Resources.Types.Textile, 1]],


If you look at the roadmap and code, I regroup resources in tiers.

T1 / Sailors => Gathering, Collecting, like get wood / construct building with woods
T2 / Pioneers => First transform, like wood in planks / construct building with planks
etc...

So, currently you work on the v0.02 and not on v0.01

Added new building sawmill which uses wood to generate boards / planks.
Using the flipped image and icon of the lumberjack because no specific icon and image are in the old game :/

theludovyc · 2024-11-11T10:37:15Z

theLudovyc/GUI/BuildingContainer.gd

@@ -8,15 +8,15 @@ extends VBoxContainer

 @onready var confirmation_dialog := %ConfirmationDialog

-const confirmation_text = "Are you sure you want to demolish this building?"
+const confirmation_text: String = "Are you sure you want to demolish this building?"


You do not need to type a constant. Instead of variable they are not Variant. They are typed are at creation. https://docs.godotengine.org/en/stable/tutorials/scripting/gdscript/gdscript_basics.html#constants

theludovyc · 2024-11-11T10:39:54Z

theLudovyc/GUI/BuildingProducingContainer.gd

@@ -1,4 +1,5 @@
 extends VBoxContainer
+class_name BuildingProducingContainer


You do not need to add the class_name specifier if you do not use this class outside

theLudovyc/GUI/ResourceControl.gd

theludovyc · 2024-11-11T10:46:42Z

theLudovyc/Resources/Resources.gd

-
-
-enum LevelTypes { Gathered, TransformedOnce, TransformedTwice }
+	return AllResources.get(resource_type)[2]


Regroup the datas is a good idea. But here, you do not handle the case where resource_type can be not found

To be fair - your code did not either ;)

What should be the outcome if the type is not found? A dummy icon?

I do this with

static func get_resource_icon(resource_type: Types) -> Texture2D: return Icons.get(resource_type)

From the doc about Dictionary.get(...) If the key does not exist, returns default, or null if the parameter is omitted.

In your proposal you can call [2] on a null value

theludovyc · 2024-11-11T10:47:17Z

theLudovyc/Resources/Resources.gd


-const Levels = {Types.Wood: LevelTypes.Gathered, Types.Textile: LevelTypes.TransformedTwice}
+
+static func get_rescources_level(resource_type: Types):


This is bad, do not return 0 please.

Removed unused method

theludovyc · 2024-11-11T10:47:53Z

theLudovyc/TheFactory.gd


 var workers := 0:
 	set(value):
 		workers = value
 		event_bus.available_workers_updated.emit(game.population - workers)

-enum Waiting_Lines { resource_type, needed_workers }
-var waiting_lines = []
+var waiting_line_buildings: Array[Building2D] = []


I like the way you use building here. But please respect the MVC architecture

theludovyc · 2024-11-11T10:52:46Z

theLudovyc/TheMarket.gd

-		return 0
-
-	return Resources.Levels[resource_type] + 1
+	#TODO Michael: check this method


#TODO Michael: check this method

Adjusted method to current implementation.

theludovyc · 2024-11-11T10:53:15Z

theLudovyc/TheStorage.gd

@@ -50,18 +50,8 @@ func try_to_sell_resource(resource_type: Resources.Types, amount: int) -> bool:
 	return false


-func update_global_production_rate(resource_type: Resources.Types):


If you remove it, how do you send the resource update ? 🤔

WIth storage.add_resource().

I mean the resource production rate per tick, with event_bus.resource_prodution_rate_updated

…to fit the MVC pattern

Producing boards from wood

theludovyc · 2024-11-18T21:42:39Z

theLudovyc/Game2D.gd

@@ -9,11 +9,11 @@ class_name Game2D

 @onready var node_entities := %Entities

-@onready var the_storage := $TheStorage
+@onready var the_storage: TheStorage = $TheStorage


Okay maybe it can help on the @onready var , and you need to write the type. But please try to add just the necessary ( := , and yes typing variable increase performances). GdScript is a scripting language, dynamically and weakly typed. I know it can be hard for a Java programmer, but try your best please 😊

theludovyc · 2024-11-18T21:44:40Z

theLudovyc/TheFactory.gd

-			i += 1
+			i = i + 1


Seriously ? 😅

theludovyc · 2024-11-18T21:48:17Z

theLudovyc/TheFactory.gd

+	for single_building in buildings:
+		if is_instance_of(single_building, ProductionBuildingModel):


This algorithm is not efficient. Maybe you can make an array with just ProductionBuildings in theFactory.

theludovyc · 2024-11-18T21:49:15Z

theLudovyc/TheFactory.gd

+	for building_model in buildings:
+		if building_model.id == id:
+			return building_model


This algorithm is not efficient. Maybe you can make a dictionary [id]=building_model .

theludovyc · 2024-11-18T21:50:35Z

theLudovyc/TheStorage.gd

@@ -50,18 +50,8 @@ func try_to_sell_resource(resource_type: Resources.Types, amount: int) -> bool:
 	return false


-func update_global_production_rate(resource_type: Resources.Types):


I mean the resource production rate per tick, with event_bus.resource_prodution_rate_updated

theludovyc · 2024-11-18T21:52:24Z

theLudovyc/Game2D.gd

+	var uuid: String = uuid_util.v4()
+	instance.id = uuid


Why did not you write instance.id = uuid_util.v4() ?

theludovyc · 2024-11-18T21:54:36Z

theLudovyc/Building/ProductionBuildingModel.gd

+		sendProducedItems(storage)
+		produce()
+		collect(storage)
+
+
+func collect(storage: TheStorage):
+	var amount: int = 1
+	if storage.has_enough_resources(amount, getNeedItemType()):
+		storage.add_resource(getNeedItemType(), -amount)
+		input_resource_amount = input_resource_amount + amount
+
+
+func produce():
+	if input_resource_amount > 0:
+		input_resource_amount = input_resource_amount - 1
+		output_resource_amount = output_resource_amount + 1
+
+
+func sendProducedItems(storage: TheStorage):
+		var output: int = output_resource_amount
+		output_resource_amount = 0
+		storage.add_resource(getProducedItemType(), output)


Why did you make 3 methods who are called just once ?

Creating boards from wood in a building

dfc18bf

Removing the production and now buildings are added to the factory. Buildings now keep information about the current workers and the amount of produces goods.

LinuxDonald requested a review from theludovyc November 10, 2024 18:07

theludovyc requested changes Nov 11, 2024

View reviewed changes

Michael Kröll added 2 commits November 13, 2024 16:41

Splitting Buildings / ProductionBuilding into view and model in oder …

b16e423

…to fit the MVC pattern

Creating Sawmill

4d6bed0

Producing boards from wood

TheSephyr requested a review from theludovyc November 14, 2024 18:44

Michael Kröll added 2 commits November 14, 2024 20:39

Adjusting to code review

24092bb

Removing unused class

a413f64

theludovyc requested changes Nov 18, 2024

View reviewed changes

Code improvements

3db43c3

TheSephyr closed this Nov 24, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Creating boards from wood in a building #124

Creating boards from wood in a building #124

TheSephyr commented Nov 10, 2024

theludovyc Nov 11, 2024 •

edited

Loading

TheSephyr Nov 14, 2024

theludovyc Nov 11, 2024 •

edited

Loading

TheSephyr Nov 14, 2024

theludovyc Nov 11, 2024

theludovyc Nov 11, 2024

theludovyc Nov 11, 2024

TheSephyr Nov 11, 2024

theludovyc Nov 19, 2024

theludovyc Nov 11, 2024

TheSephyr Nov 14, 2024

theludovyc Nov 11, 2024

TheSephyr Nov 14, 2024

theludovyc Nov 11, 2024

TheSephyr Nov 14, 2024

theludovyc Nov 11, 2024

TheSephyr Nov 14, 2024

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024 •

edited

Loading

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024

theludovyc Nov 18, 2024

		@@ -1,4 +1,5 @@
		extends VBoxContainer
		class_name BuildingProducingContainer



		enum LevelTypes { Gathered, TransformedOnce, TransformedTwice }
		return AllResources.get(resource_type)[2]


		const Levels = {Types.Wood: LevelTypes.Gathered, Types.Textile: LevelTypes.TransformedTwice}

		static func get_rescources_level(resource_type: Types):

		@@ -50,18 +50,8 @@ func try_to_sell_resource(resource_type: Resources.Types, amount: int) -> bool:
		return false


		func update_global_production_rate(resource_type: Resources.Types):

		for single_building in buildings:
		if is_instance_of(single_building, ProductionBuildingModel):

Creating boards from wood in a building #124

Creating boards from wood in a building #124

Conversation

TheSephyr commented Nov 10, 2024

theludovyc Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theludovyc Nov 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theludovyc Nov 18, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

theludovyc Nov 11, 2024 •

edited

Loading

theludovyc Nov 11, 2024 •

edited

Loading

theludovyc Nov 18, 2024 •

edited

Loading