changing volume template

[clayrosenthal]

User description

Changing the volumeRequestTemplate to pass the whole .spec in, rather than specific fields.

Fixes #21

---

PR Type

Enhancement

---

Description

• Updated the volume template in statefulset.yaml to pass the entire .spec object instead of specific fields.
• Removed explicit references to accessModes and resources.requests.storage.
• Improved template readability and maintainability by using the toYaml function.

---

Changes walkthrough 📝

	Relevant files
Enhancement	statefulset.yaml Update volume template to pass entire `.spec` object          charts/vespa/templates/statefulset.yaml Changed volume template to pass the entire .spec object. Removed specific field references for accessModes and resources.requests.storage. Utilized toYaml function for better readability and maintainability. +2/-5

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[qodo-merge-pro]

PR Review 🔍

⏱️ Estimated effort to review [1-5]	2, because the changes are limited to a single file and involve simplifying the template by using a more dynamic YAML rendering approach. The logic is straightforward and the amount of changed code is small.
🧪 Relevant tests	No
⚡ Possible issues	Possible Bug: The change assumes that all necessary fields are present in .spec without null values. If .spec is incomplete or improperly formatted, this could lead to runtime errors or misconfigurations in the stateful set.
🔒 Security concerns	No

[qodo-merge-pro]

PR Code Suggestions ✨

Category	Suggestion	Score
Best practice	Adjust the indentation level for the toYaml function to ensure consistent formatting Ensure that the toYaml function properly handles indentation and formatting by using nindent with a consistent value. This helps avoid potential formatting issues. charts/vespa/templates/statefulset.yaml [63] -{{- toYaml .spec | nindent 6 }} +{{- toYaml .spec | nindent 8 }} Apply this suggestion Suggestion importance[1-10]: 5 Why: The suggestion to adjust the indentation from 6 to 8 in the toYaml function is valid for consistency and readability. However, without more context on the surrounding code's indentation levels, it's hard to definitively say if 8 is the correct indentation level over 6. Thus, the suggestion is potentially beneficial but not critical.	5