Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ApplicationDataContainerSettings, sub-containers, SetVersionRequest #16910

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from
Draft

[WIP] ApplicationDataContainerSettings, sub-containers, SetVersionRequest #16910

wants to merge 18 commits into from

Conversation

MartinZikmund
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform area/skia ✏️ Categorizes an issue or PR as relevant to Skia labels May 29, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

3 similar comments
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from b44a167 to c0f1ed6 Compare June 17, 2024 12:34
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund changed the title [WIP] ApplicationDataContainerSettings, ApplicationDataCompositeValue, SetVersionRequest [WIP] ApplicationDataContainerSettings, sub-containers, SetVersionRequest Jun 18, 2024
@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from c0f1ed6 to c1e69f7 Compare June 19, 2024 07:42
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from 5de53e5 to ed7626d Compare June 20, 2024 08:00
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from ed7626d to f1b0557 Compare June 21, 2024 09:30
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from f1b0557 to e4a28d3 Compare August 26, 2024 13:04
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from e4a28d3 to a4939a3 Compare September 3, 2024 16:35
MartinZikmund
MartinZikmund commented Sep 3, 2024
View reviewed changes
src/Uno.UWP/Generated/3.0.0.0/Windows.Storage/ApplicationData.cs
@@ -114,7 +114,7 @@ public uint Version
}
#endif
// Forced skipping of method Windows.Storage.ApplicationData.Version.get
#if __ANDROID__ || __IOS__ || IS_UNIT_TESTS || __WASM__ || __SKIA__ || __NETSTD_REFERENCE__ || __MACOS__
#if false
[global::Uno.NotImplemented("__ANDROID__", "__IOS__", "IS_UNIT_TESTS", "__WASM__", "__SKIA__", "__NETSTD_REFERENCE__", "__MACOS__")]
public global::Windows.Foundation.IAsyncAction SetVersionAsync(uint desiredVersion, global::Windows.Storage.ApplicationDataSetVersionHandler handler)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO Implement using private Uno key

MartinZikmund
MartinZikmund commented Sep 3, 2024
View reviewed changes
src/Uno.UWP/Generated/3.0.0.0/Windows.Storage/ApplicationDataContainer.cs
@@ -25,21 +25,21 @@ public partial class ApplicationDataContainer : global::System.IDisposable
// Forced skipping of method Windows.Storage.ApplicationDataContainer.Locality.get
// Forced skipping of method Windows.Storage.ApplicationDataContainer.Values.get
// Forced skipping of method Windows.Storage.ApplicationDataContainer.Containers.get
#if __ANDROID__ || __IOS__ || IS_UNIT_TESTS || __WASM__ || __SKIA__ || __NETSTD_REFERENCE__ || __MACOS__
#if false
[global::Uno.NotImplemented("__ANDROID__", "__IOS__", "IS_UNIT_TESTS", "__WASM__", "__SKIA__", "__NETSTD_REFERENCE__", "__MACOS__")]
public global::Windows.Storage.ApplicationDataContainer CreateContainer(string name, global::Windows.Storage.ApplicationDataCreateDisposition disposition)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add runtime tests for creating, deleting, and nesting of containers

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

1 similar comment
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or it will be closed in 10 days.

@github-actions github-actions bot added the stale This item has been marked as stale and will be closed if there is no activity. label Feb 12, 2025
@MartinZikmund MartinZikmund removed the stale This item has been marked as stale and will be closed if there is no activity. label Feb 20, 2025
@MartinZikmund MartinZikmund force-pushed the dev/mazi/appdatacontainerers branch from daf2c40 to 576040b Compare February 20, 2025 10:18
@MartinZikmund
Copy link
Member Author

There was a change in WASM JSExport name that needs to be brought in here - aa6fdd2

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16910/index.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/android 🤖 Categorizes an issue or PR as relevant to the Android platform platform/ios 🍎 Categorizes an issue or PR as relevant to the iOS platform platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform platform/wasm 🌐 Categorizes an issue or PR as relevant to the WebAssembly platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinZikmund @unodevops