Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(skia): support ImageBrushes with svg URIs #19429

Merged
merged 6 commits into from
Feb 20, 2025
Merged

feat(skia): support ImageBrushes with svg URIs #19429

merged 6 commits into from
Feb 20, 2025

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #19192

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Feb 6, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154336 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154466 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154516 has failed on Uno.UI - CI.

@github-actions github-actions bot added the area/build Categorizes an issue or PR as relevant to build infrastructure label Feb 11, 2025
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154812 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 154898 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19429/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 155489 has failed on Uno.UI - CI.

@jeromelaban jeromelaban disabled auto-merge February 20, 2025 16:24
@jeromelaban jeromelaban merged commit 6e07c45 into unoplatform:master Feb 20, 2025
113 of 115 checks passed
@ramezgerges ramezgerges deleted the imagebrush_svg_skia branch February 20, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/build Categorizes an issue or PR as relevant to build infrastructure area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Skia] ImageBrush_Formats is not reliable
3 participants
@ramezgerges @unodevops @jeromelaban