Strict PHP inspection

src/Abstracts/CustomType.php

@@ -12,5 +12,5 @@
  */
 abstract class CustomType extends TelegramTypes
 {
-    public $data = null;
+    public $data = [];
 }

src/Abstracts/TelegramMethods.php

@@ -68,6 +68,7 @@ public function performSpecialConditions(): TelegramMethods
      * Exports the class to an array in order to send it to the Telegram servers without extra fields that we don't need
      *
      * @return array
+     * @throws MissingMandatoryField
      */
     final public function export(): array
     {
@@ -77,7 +78,7 @@ final public function export(): array
         $cleanObject = new $this();
         foreach ($cleanObject as $fieldId => $value) {
             if ($this->$fieldId === $cleanObject->$fieldId) {
-                if (in_array($fieldId, $mandatoryFields)) {
+                if (in_array($fieldId, $mandatoryFields, true)) {
                     throw new MissingMandatoryField(sprintf(
                         'The field "%s" is mandatory and empty, please correct',
                         $fieldId

src/Interfaces/CustomArrayType.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types = 1);
+
 namespace unreal4u\TelegramAPI\Interfaces;
 
 use Psr\Log\LoggerInterface;

src/Telegram/Methods/DeleteWebhook.php

@@ -9,7 +9,6 @@
 use unreal4u\TelegramAPI\Abstracts\TelegramTypes;
 use unreal4u\TelegramAPI\InternalFunctionality\TelegramRawData;
 use unreal4u\TelegramAPI\Telegram\Types\Custom\ResultBoolean;
-use unreal4u\TelegramAPI\Telegram\Types\User;
 
 /**
  * Use this method to remove webhook integration if you decide to switch back to getUpdates. Returns True on success.

src/Telegram/Methods/GetFile.php

@@ -32,7 +32,7 @@ class GetFile extends TelegramMethods
     /**
      * This call will return an array with updates, so call up a custom type to do this
      *
-     * @param array $data
+     * @param TelegramRawData $data
      * @param LoggerInterface $logger
      * @return TelegramTypes
      */

src/Telegram/Methods/GetGameScore.php

@@ -7,11 +7,8 @@
 use Psr\Log\LoggerInterface;
 use unreal4u\TelegramAPI\Abstracts\TelegramMethods;
 use unreal4u\TelegramAPI\Abstracts\TelegramTypes;
-use unreal4u\TelegramAPI\Exceptions\InvalidResultType;
 use unreal4u\TelegramAPI\InternalFunctionality\TelegramRawData;
 use unreal4u\TelegramAPI\Telegram\Types\Custom\GameHighScoreArray;
-use unreal4u\TelegramAPI\Telegram\Types\Custom\ResultBoolean;
-use unreal4u\TelegramAPI\Telegram\Types\Message;
 
 /**
  * Use this method to get data for high score tables. Will return the score of the specified user and several of his

src/Telegram/Methods/GetUserProfilePhotos.php

@@ -40,7 +40,7 @@ class GetUserProfilePhotos extends TelegramMethods
     /**
      * This call will return an array with updates, so call up a custom type to do this
      *
-     * @param array $data
+     * @param TelegramRawData $data
      * @param LoggerInterface $logger
      * @return TelegramTypes
      */

src/Telegram/Methods/SendAudio.php

@@ -4,6 +4,7 @@
 
 namespace unreal4u\TelegramAPI\Telegram\Methods;
 
+use unreal4u\TelegramAPI\Abstracts\KeyboardMethods;
 use unreal4u\TelegramAPI\Abstracts\TelegramMethods;
 use unreal4u\TelegramAPI\Telegram\Types\Custom\InputFile;
 
@@ -80,9 +81,9 @@ class SendAudio extends TelegramMethods
     /**
      * Optional. Additional interface options. A JSON-serialized object for a custom reply keyboard, instructions to
      * hide keyboard or to force a reply from the user
-     * @var null
+     * @var KeyboardMethods
      */
-    public $reply_markup = null;
+    public $reply_markup;
 
     public function getMandatoryFields(): array
     {

src/Telegram/Methods/SendGame.php

@@ -47,7 +47,7 @@ class SendGame extends TelegramMethods
      * hide keyboard or to force a reply from the user.
      * @var Markup
      */
-    public $reply_markup = null;
+    public $reply_markup;
 
     public function getMandatoryFields(): array
     {

src/Telegram/Types/Custom/ChatMembersArray.php

@@ -14,11 +14,9 @@
  */
 class ChatMembersArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $id => $chatMember) {
                 $this->data[$id] = new ChatMember($chatMember, $logger);
             }

src/Telegram/Types/Custom/GameHighScoreArray.php

@@ -15,11 +15,9 @@
  */
 class GameHighScoreArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $id => $gameHighScore) {
                 $this->data[$id] = new GameHighScore($gameHighScore, $logger);
             }

src/Telegram/Types/Custom/InlineKeyboardButtonArray.php

@@ -14,11 +14,9 @@
  */
 class InlineKeyboardButtonArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $rowId => $button) {
                 $this->data[$rowId][] = new Button($data, $logger);
             }

src/Telegram/Types/Custom/InputFile.php

@@ -24,7 +24,7 @@ class InputFile
      * The actual stream to the file
      * @var resource
      */
-    private $stream = null;
+    private $stream;
 
     public function __construct(string $path)
     {
@@ -36,6 +36,7 @@ public function __construct(string $path)
      * Will setup the stream
      *
      * @return InputFile
+     * @throws FileNotReadable
      */
     private function setStream(): InputFile
     {

src/Telegram/Types/Custom/KeyboardButtonArray.php

@@ -14,11 +14,9 @@
  */
 class KeyboardButtonArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $rowId => $button) {
                 $this->data[$rowId][] = new KeyboardButton($data, $logger);
             }

src/Telegram/Types/Custom/MessageEntityArray.php

@@ -14,11 +14,9 @@
  */
 class MessageEntityArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $id => $messageEntity) {
                 $this->data[$id] = new MessageEntity($messageEntity, $logger);
             }

src/Telegram/Types/Custom/PhotoSizeArray.php

@@ -14,11 +14,9 @@
  */
 class PhotoSizeArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $id => $photo) {
                 $this->data[$id] = new PhotoSize($photo, $logger);
             }

src/Telegram/Types/Custom/UpdatesArray.php

@@ -14,11 +14,9 @@
  */
 class UpdatesArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             foreach ($data as $telegramResponse) {
                 // Create an actual Update object and fill the array
                 $this->data[] = new Update($telegramResponse, $logger);

src/Telegram/Types/Custom/UserProfilePhotosArray.php

@@ -14,12 +14,11 @@
  */
 class UserProfilePhotosArray extends CustomType implements CustomArrayType
 {
-    public $data = [];
-
     public function __construct(array $data = null, LoggerInterface $logger = null)
     {
-        if (!empty($data)) {
+        if (count($data) !== 0) {
             $i = 0;
+            /** @var array $telegramResponse */
             foreach ($data as $telegramResponse) {
                 foreach ($telegramResponse as $photoSize) {
                     // Create an actual PhotoSize object and fill the array

src/Telegram/Types/Game.php

@@ -54,7 +54,7 @@ class Game extends TelegramTypes
      * Optional. Animation that will be displayed in the game message in chats. Upload via BotFather
      * @var Animation
      */
-    public $animation = null;
+    public $animation;
 
     public function mapSubObjects(string $key, array $data): TelegramTypes
     {

src/Telegram/Types/GameHighScore.php

@@ -5,8 +5,6 @@
 namespace unreal4u\TelegramAPI\Telegram\Types;
 
 use unreal4u\TelegramAPI\Abstracts\TelegramTypes;
-use unreal4u\TelegramAPI\Telegram\Types\Custom\MessageEntityArray;
-use unreal4u\TelegramAPI\Telegram\Types\Custom\PhotoSizeArray;
 
 /**
  * This object represents one row of the high scores table for a game
@@ -25,7 +23,7 @@ class GameHighScore extends TelegramTypes
 
     /**
      * User
-     * @var string
+     * @var User
      */
     public $user;
 

src/Telegram/Types/Inline/Query/Result.php

@@ -55,7 +55,7 @@ abstract class Result extends TelegramTypes
      * Optional. Inline keyboard attached to the message
      * @var Markup
      */
-    public $reply_markup = null;
+    public $reply_markup;
 
     protected function mapSubObjects(string $key, array $data): TelegramTypes
     {
@@ -85,6 +85,7 @@ public function getMandatoryFields(): array
      *
      * @see TelegramMethods::export
      * @return array
+     * @throws \unreal4u\TelegramAPI\Exceptions\MissingMandatoryField
      */
     public function export(): array
     {
@@ -94,7 +95,7 @@ public function export(): array
         $cleanObject = new $this();
         foreach ($cleanObject as $fieldId => $value) {
             if ($fieldId !== 'type' && $this->$fieldId === $cleanObject->$fieldId) {
-                if (in_array($fieldId, $mandatoryFields)) {
+                if (in_array($fieldId, $mandatoryFields, true)) {
                     throw new MissingMandatoryField(sprintf(
                         'The field "%s" is mandatory and empty, please correct',
                         $fieldId

src/Telegram/Types/Inline/Query/Result/Article.php

@@ -68,5 +68,5 @@ class Article extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Audio.php

@@ -57,5 +57,5 @@ class Audio extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Audio.php

@@ -40,5 +40,5 @@ class Audio extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Document.php

@@ -52,5 +52,5 @@ class Document extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Gif.php

@@ -46,5 +46,5 @@ class Gif extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Mpeg4Gif.php

@@ -46,5 +46,5 @@ class Mpeg4Gif extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Photo.php

@@ -52,5 +52,5 @@ class Photo extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Sticker.php

@@ -33,5 +33,5 @@ class Sticker extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Video.php

@@ -52,5 +52,5 @@ class Video extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Cached/Voice.php

@@ -46,5 +46,5 @@ class Voice extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Contact.php

@@ -63,5 +63,5 @@ class Contact extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Document.php

@@ -76,5 +76,5 @@ class Document extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Gif.php

@@ -64,5 +64,5 @@ class Gif extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Location.php

@@ -63,5 +63,5 @@ class Location extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Mpeg4Gif.php

@@ -64,5 +64,5 @@ class Mpeg4Gif extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Photo.php

@@ -69,5 +69,5 @@ class Photo extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }

src/Telegram/Types/Inline/Query/Result/Venue.php

@@ -75,5 +75,5 @@ class Venue extends Result
      * Optional. Content of the message to be sent instead of the audio/document/voice message/video/sticker/etc.
      * @var InputMessageContent
      */
-    public $input_message_content = null;
+    public $input_message_content;
 }