Fix: JS: Improve error handling of batch addition #510
+36
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch fixes the crash, but is there a better way? |
Crash if there is an error in batch addition.
Example:
```
const usearch = require('usearch');
const index = new usearch.Index({ metric: 'l2sq', connectivity: 16, dimensions: 3 });
index.add(42n, new Float32Array([0.2, 0.6, 0.4]));
index.add(
[41n, 42n, 43n],
[[0.1, 0.6, 0.4], [0.2, 0.6, 0.4], [0.3, 0.6, 0.4]]
)
```
`42n` is duplicated, which causes an error, but then it crash.
It seems that it is not better to throw an exception during the process,
so we changed it to throw it after it is completed.
abetomo
force-pushed
the
fix-batch-additions
branch
from
aaf832a
to
b20a6e9
Compare
ashvardanian
requested changes
Nov 1, 2024
javascript/lib.cpp
Outdated
Comment on lines
168
to
177
| std::string error = ""; | ||
| executor_stl_t executor; | ||
| executor.fixed(tasks, [&](std::size_t /*thread_idx*/, std::size_t task_idx) { | ||
| add_result_t result = native_->add(static_cast<default_key_t>(keys[task_idx]), | ||
| vectors + task_idx * native_->dimensions()); | ||
| if (!result) | ||
| Napi::Error::New(ctx.Env(), result.error.release()).ThrowAsJavaScriptException(); | ||
| error += "<key:" + std::to_string(keys[task_idx]) + " message:" + result.error.release() + ">"; | ||
| }); | ||
| if (error.size() > 0) | ||
| Napi::Error::New(ctx.Env(), error).ThrowAsJavaScriptException(); |
There was a problem hiding this comment.
This is not thread-safe. You need a mutex to safeguard the error string. Moreover, your solution may result in a heap allocation in the default string constructor. There should be a way to avoid it.
There was a problem hiding this comment.
Thanks for the review.
I understand that adding it to a string is not a good idea, but I would like to know if there is a better way to handle errors in such cases.
Would a Python implementation be helpful?
https://github.com/unum-cloud/usearch/blob/main/python/lib.cpp#L180-L211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crash if there is an error in batch addition.
Example:
42nis duplicated, which causes an error, but then it crash.It seems that it is not better to throw an exception during the process, so we changed it to throw it after it is completed.