Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert unittesting #50

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Convert unittesting #50

wants to merge 4 commits into from

Conversation

GregJohnsonJr
Copy link
Collaborator

@GregJohnsonJr GregJohnsonJr commented Aug 24, 2023

To demonstrate that some parameters were not translating properly, I created a unit test to assess the convert function. In particular, the mass_diff_to_variable_mod is not converting properly (Parameters will be added to this PR based on when I find them). Please let me know if we need more information! (This is a failing test)

@GregJohnsonJr GregJohnsonJr self-assigned this Aug 24, 2023
@StSchulze
Copy link
Contributor

Quick comment:
We originally thought that the translation wasn't working for some parameters, but it turned out to be a false alarm.
However, in the process we also realized that the "was_translated" flag isn't always set to true, even if the value translation actually worked, like in this case here for write_mass_diff_to_variable_mod.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants