Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ops(github): fix GitHub workflow #376

Merged
merged 7 commits into from
Jan 13, 2025
Merged

Conversation

Danipulok
Copy link
Contributor

@Danipulok Danipulok commented Jan 11, 2025

What this PR does?

Now the workflow works successfully.

What's changed in details:

  • Fix README.md, since it failed lint rules;
  • Pin workflow Ubuntu version to ubuntu-22.04, since ubuntu-24.04 does not support python3.7 (src);
  • Remove running demo from workflow, since the toke is required;

You can see that the workflow now passes here:

https://github.com/Danipulok/pixivpy/actions/runs/12727727257

@Danipulok Danipulok marked this pull request as draft January 11, 2025 19:59
@Danipulok Danipulok marked this pull request as ready for review January 11, 2025 21:25
@Danipulok Danipulok changed the title ops(github): fix readme to pass GitHub workflow ops(github): fix GitHub workflow Jan 11, 2025
@Danipulok
Copy link
Contributor Author

@upbit , please check

@upbit upbit merged commit 7b72543 into upbit:master Jan 13, 2025
2 checks passed
@upbit
Copy link
Owner

upbit commented Jan 13, 2025

Thanks for contribution! Merged.

@Danipulok Danipulok deleted the ops/fix-workflow branch January 13, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants