Enable ESLint latest rules and database query name checks #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eprince-hub
commented
Oct 17, 2024
| import { ReactNode } from 'react'; | ||
| import type { ReactNode } from 'react'; |
There was a problem hiding this comment.
Import all types using type-only import
Eprince-hub
commented
Oct 17, 2024
| declare module globalThis { | ||
| declare namespace globalThis { |
There was a problem hiding this comment.
Module is now called namespace
Eprince-hub
commented
Oct 17, 2024
| import u from 'eslint-config-upleveled';const c=u.filter(d=>d.name!=='upleveled:database-auth');export default c; | ||
| export { default } from 'eslint-config-upleveled'; |
There was a problem hiding this comment.
Remove the ESLint disable for database function name auth
Eprince-hub
commented
Oct 17, 2024
Comment on lines
+1
to
+16
| import type { NextConfig } from 'next'; | ||
|
|
||
| const nextConfig: NextConfig = { | ||
| experimental: { | ||
| dynamicIO: true, | ||
| typedRoutes: true, | ||
| }, | ||
| eslint: { | ||
| ignoreDuringBuilds: true, | ||
| }, | ||
| typescript: { | ||
| ignoreBuildErrors: true, | ||
| }, | ||
| }; | ||
|
|
||
| export default nextConfig; |
There was a problem hiding this comment.
Use the latest next. config setting
Eprince-hub
commented
Oct 17, 2024
| @@ -11,6 +11,7 @@ const codegenConfig: CodegenConfig = { | |||
|
|
|||
| config: { | |||
| contextType: '../app/api/graphql/route#Context', | |||
| useTypeImports: true, | |||
There was a problem hiding this comment.
Make codegen use type-only import for types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added this
import u from 'eslint-config-upleveled';const c=u.filter(d=>d.name!=='upleveled:database-auth');export default c;to theeslint.config.jsfile to disable the linting of the database query names as we were not adding a real session token to the GraphQL lecture but now we are using real authentication so we should allow this rule again so we can be guided on how we write authenticated and unauthenticated database query function names.Update the packages and fix the type imports to respect the latest ESLint config checks