-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Windows long path workaround #572
Remove Windows long path workaround #572
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
size-limit report 📦
|
Confirmed that CI is passing in Reverted the Node.js version change in We will have to wait until Node.js v22 enters LTS in October to merge this one. |
Ok, I'm wrong - it seems like the latest workflow test run passed... 🤔 So maybe there were multiple Windows long pathname bugs in Node.js, and maybe this one was fixed in the earlier PR? Either way, it's passing now, so we can already merge now 🙌 |
I encountered this problem again today in a new test run:
I guess the pnpm paths weren't long enough to trigger the errors. Since Node.js v22 is becoming LTS imminently, I've upgraded ahead of time in our CI, which resolved the issue:
|
Test new Windows long path support added in Node.js v22.7.0:
LongPathsEnabled
enabled nodejs/node#50753 (comment)