-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client.trigger #18
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CahidArda
force-pushed
the
DX-1404-trigger-workflow
branch
from
November 7, 2024 14:31
5e34c22
to
54aa654
Compare
CahidArda
force-pushed
the
DX-1404-trigger-workflow
branch
from
November 7, 2024 14:34
3df5c91
to
3d4d908
Compare
const context = new WorkflowContext({ | ||
qstashClient: this.client, | ||
// @ts-expect-error headers type mismatch | ||
headers: new Headers(headers ?? {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
headers: new Headers(headers ?? {}), | |
headers: new Headers((headers ?? {}) as Record<string, string>), |
sth like this would probably work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue is not headers ?? {}
not being a valid parameter for Headers
, it's the incompatibility of Headers
with headers
:
Type 'Headers' is missing the following properties from type 'Headers': toJSON, count, getAll
fahreddinozcan
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a method for triggering workflows which returns the workflow run id. It is now possible to:
the result workflow run id will always have
wfr_
prefix.Workflow Run Id Selection
when passing a workflow run id, users should use a different workflow run id used everytime. Otherwise, there could be issues in the console view. In the image below, finished workflow runs show RUN_STARTED because another run is ongoing with the same id:
We will try to address this issue.