Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

event notification dx improvements #23

Merged
merged 9 commits into from
Nov 19, 2024
Merged

event notification dx improvements #23

merged 9 commits into from
Nov 19, 2024

Conversation

joschan21
Copy link
Contributor

@joschan21 joschan21 commented Nov 14, 2024 •
edited by CahidArda
Loading

Updates parameters of context.waitForEvent:

context.waitForEvent(
  "wait step",
  "eventId"
- "10s"
+ { timeout: "10s" }
)

@linear Linear
Copy link

linear bot commented Nov 14, 2024

DX-1409 workflow - improve event waiting dx

@CahidArda
Copy link
Collaborator

looks a lot better @joschan21, can you resolve the conflicts too?

@CahidArda CahidArda merged commit 5b345d6 into main Nov 19, 2024
17 checks passed
@CahidArda CahidArda deleted the dx-1409-workflow-dx branch November 19, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mehmettokgoz mehmettokgoz mehmettokgoz left review comments

@CahidArda CahidArda CahidArda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joschan21 @CahidArda @mehmettokgoz