Custom auth in failure function #28
Merged
+313
−58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
initial payload is still accessible through context.initialPayload
run state would become run_success. now it becomes run_canceled
they are disabled because they are unreliable in CI. will run locally instead.
when retry was 0, it wasn't being set because of 'if (retries)'. in context.call, if the endpoint we call returns an undefined body, the body field in the callback is not set. We replace this with empty string.
redis.fail allows us to mark a test as failed. if it's called, checkRedisForResults will fail.
Comment on lines
+91
to
+93
| await redis.increment(route, randomId) | ||
| await redis.saveResultsWithoutContext(route, randomId, result) | ||
| await redis.checkRedisForResults(route, randomId, 1, result) |
There was a problem hiding this comment.
Why do we check this? We already know it'd work
There was a problem hiding this comment.
just a checkpoint to make sure that the state is set in redis, and only difference is the failWithoutContext method
fahreddinozcan
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run custom auth in failureFunction by default.
also fixes:
(retries), so when it was set to 0, it wasn't being set properly.